test: add unit tests for useMultiSigProposals hook - #900
Open
Horlarmmy wants to merge 1 commit into
Open
Conversation
|
@Horlarmmy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added unit test coverage for
useMultiSigProposalshook, which manages multi-sig proposal state (creation, signing, cancellation, execution) via localStorage.Changes
src/__tests__/hooks/useMultiSigProposals.test.tsx(new)194 lines covering 12 test cases across 5
describegroups:campaignId; re-filters oncampaignIdchange[]walletAddressisnull; no-ops when active proposal exists; persists to localStoragereadywhen threshold met; no-ops whenwalletAddressisnullcancelled; sets status toexecutedwithtxHashVerification
Imports and patterns match existing hook tests (
useCampaign.test.tsx). No changes were needed to the source hook — the hook already updates state synchronously insidecreateProposal, which satisfies the "refetch after submission" acceptance criterion.Closes #803